Skip to content

Change namespace#10

Merged
lonnieezell merged 8 commits intocodeigniter4:developfrom
michalsn:namespace
Dec 17, 2023
Merged

Change namespace#10
lonnieezell merged 8 commits intocodeigniter4:developfrom
michalsn:namespace

Conversation

@michalsn
Copy link
Copy Markdown
Member

Description
Change the namespace and all related info to the codeigniter.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked at it in detail, but the tests passed.

@kenjis kenjis mentioned this pull request Dec 16, 2023
5 tasks
@michalsn
Copy link
Copy Markdown
Member Author

Thanks for the review. I guess we will have to wait until some basic permissions for members are set to merge.

@lonnieezell lonnieezell merged commit 6b9699c into codeigniter4:develop Dec 17, 2023
@michalsn michalsn deleted the namespace branch December 17, 2023 19:12
@MGatner
Copy link
Copy Markdown
Member

MGatner commented Dec 19, 2023

I'm late to the game here: are you missing merge permissions on this repo?

@michalsn
Copy link
Copy Markdown
Member Author

No, everything is fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants