refactor: fix type inconsistency

[kenjis]

Needs #10

Description

• fix type inconsistency

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[michalsn]

Good catch. Thanks.

[michalsn]

This has to be handled differently. We expect null if no value is set.

[kenjis]

Oh, thanks. Fixed. 8ec75d7#diff-29248c72207c00e6d489cddcd4e5fa9f33026a5f8503ea0b6b4f73401a3e167c

[kenjis]

And should be: 7cafc2d

[michalsn]

Thanks. I made changes to support all the params: 440d844

[kenjis]

It seems the remaining errors are bugs or API inconsistency.

 ------ ----------------------------------------------------------------------------------------- 
  Line   src/Commands/QueueWork.php                                                               
 ------ ----------------------------------------------------------------------------------------- 
  195    Call to an undefined method CodeIgniter\Queue\Interfaces\JobInterface::getTries().       
  197    Call to an undefined method CodeIgniter\Queue\Interfaces\JobInterface::getRetryAfter().  
 ------ ----------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------- 
  Line   src/Handlers/BaseHandler.php                                                               
 ------ ------------------------------------------------------------------------------------------- 
  59     Call to an undefined method CodeIgniter\Queue\Handlers\BaseHandler::push().                
  72     Call to an undefined method CodeIgniter\Queue\Models\QueueJobFailedModel::affectedRows().  
  84     Call to an undefined method CodeIgniter\Queue\Models\QueueJobFailedModel::truncate().      
 ------ ------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------- 
  Line   src/Handlers/PredisHandler.php                                                           
 ------ ----------------------------------------------------------------------------------------- 
  97     Parameter #2 $fields of method Predis\ClientInterface::hdel() expects array, int given.  
  112    Parameter #2 $fields of method Predis\ClientInterface::hdel() expects array, int given.  
  125    Parameter #2 $fields of method Predis\ClientInterface::hdel() expects array, int given.  
 ------ ----------------------------------------------------------------------------------------- 

[michalsn]

Thanks!

Seems like QueueJobFailedModel::affectedRows() and QueueJobFailedModel::truncate() are fine, the rest is fixed in #12.

[kenjis]

I don't understand the code well, but is that model unrelated to Redis?

And you created #12, so can I close this PR?

[michalsn]

I don't understand the code well, but is that model unrelated to Redis?

No. Failed jobs are always stored in the "traditional" database.

And you created #12, so can I close this PR?

Yes, however, please don't remove the branch yet - just in case.