test: lift scaling guards above runner noise floor - #8
Merged
Conversation
The 10k/2k small measurements landed near CI's noise floor (~12ms), so ordinary scheduler/GC jitter on the large run could trip the ratio bound and abort a release. Raise the sizes so the small measurement clears ~50ms on a typical runner while keeping the same ratio bounds, best-of-3, and absolute ceiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7.
The two wall-clock scaling guards in
internal/dialects/helm/templates_test.gocompared a 4x larger input againstsmall*8 + 25ms/small*9 + 50ms. On a shared runner the small measurement is ~12 ms, so ordinary noise on the large run tripped the bound (PR #6 ci run 34002119560:166ms vs 158ms), andrelease.ymlusesmake testas its tag gate.Change: input sizes raised to 22k/88k and 24k/96k so the small measurement is ~50 ms on a fast machine (further above the noise floor on a runner). Best-of-3, the ratio multipliers, the 4x ratio, and the 5 s ceiling are unchanged; the parser is untouched.
Evidence: with a test-local injected O(n²) loop the dense guard fails (
96k took 1.24s after 24k took 120ms; want <= 1.13s), then passes after reverting;-run ScalesNearLinearly -count=3060/60. Added local test time is about one second (0.95–1.05 s across runs).