Fix dead release test gate: use outcome, not conclusion - #306
Merged
Conversation
The release workflow's test step sets continue-on-error: true, which rewrites steps.test.conclusion to 'success' regardless of the real result. The follow-up "Delete tag on failure" step gated on steps.test.conclusion == 'failure', so it could never fire: a red suite still produced a green release and shipped the artifact. Gate on steps.test.outcome instead, which preserves the step's actual result. continue-on-error stays -- without it the job aborts before the tag-deletion step can run -- and both halves now carry a comment saying why they must be paired that way. Note this fixes the mechanical gate only. Making the suite honestly green is the other half of #255 and is not addressed here. Refs #255
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release.yml's test step setscontinue-on-error: true, and the follow-up step gates onsteps.test.conclusion:continue-on-error: truerewritesconclusiontosuccessregardless of the real result. Sosteps.test.conclusion == 'failure'is never true, "Delete tag on failure" has never once fired, and a red test suite produces a green release that publishes to PyPI.Fix
Gate on
steps.test.outcome, which preserves the step's actual result.continue-on-errorstays — removing it would fail the job immediately and the tag-deletion step could never run, which is the opposite of what's wanted. The two must be paired, so both halves now carry a comment saying why.Scope
This fixes the mechanical gate only. The other half of #255 — making the CI suite honestly green — is not addressed here, and turning a working gate on may now surface failures that were previously invisible. That is the point, but worth knowing before merging.
Refs #255