fix(cli): restore the SSO success message in setup - #459
Merged
uladzislausvetlakou merged 1 commit intoAug 4, 2026
Merged
Conversation
`✓ Authentication successful!` lives in the SSO provider's getCredentials, so it only printed when that step performed the browser login. Since codemie-ai#457 the wizard reuses the session established by the mandatory-integration gate, that step is skipped, and the login now completes with no confirmation at all. Print the message in the gate, where the login actually happens. It appears exactly once on every path: the gate announces it when it authenticates, and the SSO step still announces its own login when the gate is skipped. Fixes the 120s timeout in tests/integration/agent-setup.test.ts waiting for /Authentication successful/i. Generated with AI Co-Authored-By: codemie-ai <codemie.ai@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codemie setupno longer prints✓ Authentication successful!after the browser login.The message lives in the SSO provider's
getCredentials, so it only printed when thatstep performed the login itself. Since #457 the wizard reuses the session established by
the mandatory-integration gate, so that step is skipped and the login completes with no
confirmation.
Changes
detectLiteLLMEnforcement(), where the login actually happens.It now appears exactly once on every path: the gate announces it when it authenticates,
and the SSO step still announces its own login when the gate is skipped.
Fixes the 120s timeout in
tests/integration/agent-setup.test.tswaiting for/Authentication successful/i.Checklist
npm run ci)main