Revert #5010 changes: no confirmed underlying issue#5041
Merged
Conversation
…firmed Removes the iOS native edits and the input-validation test scaffolding that were added to chase issue #5010. The bug reporter's symptoms could not be independently reproduced, so the workarounds are removed: - pressesBegan/Ended/Cancelled editingComponent guards in CodenameOne_GLViewController (PRs #5013, #5027) - ignoreEvent extension on CN1TapGestureRecognizer (PR #5026) - CN1Log [#5010] diagnostic markers in editStringAtImpl and the press handlers (PR #5027) - KeyTypeStep + driveKeyType XCUITest scaffolding that only existed to validate the fix path (PR #5013) CodenameOne_GLViewController.m is now byte-identical to its pre-#5010 baseline; CN1TapGestureRecognizer.m differs only in two trailing- whitespace cleanups. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 110 screenshots: 110 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 107 screenshots: 107 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodenameOne_GLViewController.mis restored byte-identical to its pre-Unresposive App when trying to type to input field #5010 baseline: theeditingComponent != nilearly-return guards onpressesBegan:/pressesEnded:/pressesCancelled:and theCN1Log [#5010]diagnostic markers are gone.CN1TapGestureRecognizer.ignoreEvent:loses its extraeditingComponentdescendant check; only two trailing-whitespace cleanups remain vs the pre-Unresposive App when trying to type to input field #5010 baseline.KeyTypeStepXCUITest scaffolding (Java step, SwiftdriveKeyType, README row, driver assertions) is removed — it only existed to validate the Unresposive App when trying to type to input field #5010 fix path.Test plan
tap/drag/longpress) still runs end-to-end on the iOS simulator#5010,KeyType, orkeytypeinPorts/iOSPort/orscripts/input-validation-app/🤖 Generated with Claude Code