Skip to content

Revert #5010 changes: no confirmed underlying issue#5041

Merged
shai-almog merged 1 commit into
masterfrom
revert-5010-changes
May 26, 2026
Merged

Revert #5010 changes: no confirmed underlying issue#5041
shai-almog merged 1 commit into
masterfrom
revert-5010-changes

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • iOS port still builds (CN1TapGestureRecognizer.m + CodenameOne_GLViewController.m compile)
  • Existing input-validation suite (tap / drag / longpress) still runs end-to-end on the iOS simulator
  • No remaining references to #5010, KeyType, or keytype in Ports/iOSPort/ or scripts/input-validation-app/

🤖 Generated with Claude Code

…firmed

Removes the iOS native edits and the input-validation test scaffolding
that were added to chase issue #5010. The bug reporter's symptoms could
not be independently reproduced, so the workarounds are removed:

- pressesBegan/Ended/Cancelled editingComponent guards in
  CodenameOne_GLViewController (PRs #5013, #5027)
- ignoreEvent extension on CN1TapGestureRecognizer (PR #5026)
- CN1Log [#5010] diagnostic markers in editStringAtImpl and the press
  handlers (PR #5027)
- KeyTypeStep + driveKeyType XCUITest scaffolding that only existed to
  validate the fix path (PR #5013)

CodenameOne_GLViewController.m is now byte-identical to its pre-#5010
baseline; CN1TapGestureRecognizer.m differs only in two trailing-
whitespace cleanups.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ByteCodeTranslator: 0 findings (no issues)
    • android: 0 findings (no issues)
    • codenameone-maven-plugin: 0 findings (no issues)
    • core-unittests: 0 findings (no issues)
    • ios: 0 findings (no issues)
  • PMD: 0 findings (no issues) [Report archive]
  • Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented May 26, 2026

Compared 110 screenshots: 110 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 138 seconds

Build and Run Timing

Metric Duration
Simulator Boot 67000 ms
Simulator Boot (Run) 1000 ms
App Install 12000 ms
App Launch 16000 ms
Test Execution 301000 ms

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 429.000 ms
Base64 CN1 encode 1255.000 ms
Base64 encode ratio (CN1/native) 2.925x (192.5% slower)
Base64 native decode 336.000 ms
Base64 CN1 decode 900.000 ms
Base64 decode ratio (CN1/native) 2.679x (167.9% slower)
Base64 SIMD encode 448.000 ms
Base64 encode ratio (SIMD/native) 1.044x (4.4% slower)
Base64 encode ratio (SIMD/CN1) 0.357x (64.3% faster)
Base64 SIMD decode 418.000 ms
Base64 decode ratio (SIMD/native) 1.244x (24.4% slower)
Base64 decode ratio (SIMD/CN1) 0.464x (53.6% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 82.000 ms
Image createMask (SIMD on) 16.000 ms
Image createMask ratio (SIMD on/off) 0.195x (80.5% faster)
Image applyMask (SIMD off) 241.000 ms
Image applyMask (SIMD on) 83.000 ms
Image applyMask ratio (SIMD on/off) 0.344x (65.6% faster)
Image modifyAlpha (SIMD off) 152.000 ms
Image modifyAlpha (SIMD on) 55.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.362x (63.8% faster)
Image modifyAlpha removeColor (SIMD off) 138.000 ms
Image modifyAlpha removeColor (SIMD on) 76.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.551x (44.9% faster)
Image PNG encode (SIMD off) 866.000 ms
Image PNG encode (SIMD on) 1056.000 ms
Image PNG encode ratio (SIMD on/off) 1.219x (21.9% slower)
Image JPEG encode 665.000 ms

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented May 26, 2026

Compared 107 screenshots: 107 matched.
✅ Native iOS Metal screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 201 seconds

Build and Run Timing

Metric Duration
Simulator Boot 58000 ms
Simulator Boot (Run) 1000 ms
App Install 10000 ms
App Launch 3000 ms
Test Execution 259000 ms

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 399.000 ms
Base64 CN1 encode 1229.000 ms
Base64 encode ratio (CN1/native) 3.080x (208.0% slower)
Base64 native decode 248.000 ms
Base64 CN1 decode 1411.000 ms
Base64 decode ratio (CN1/native) 5.690x (469.0% slower)
Base64 SIMD encode 715.000 ms
Base64 encode ratio (SIMD/native) 1.792x (79.2% slower)
Base64 encode ratio (SIMD/CN1) 0.582x (41.8% faster)
Base64 SIMD decode 376.000 ms
Base64 decode ratio (SIMD/native) 1.516x (51.6% slower)
Base64 decode ratio (SIMD/CN1) 0.266x (73.4% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 57.000 ms
Image createMask (SIMD on) 9.000 ms
Image createMask ratio (SIMD on/off) 0.158x (84.2% faster)
Image applyMask (SIMD off) 120.000 ms
Image applyMask (SIMD on) 61.000 ms
Image applyMask ratio (SIMD on/off) 0.508x (49.2% faster)
Image modifyAlpha (SIMD off) 137.000 ms
Image modifyAlpha (SIMD on) 65.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.474x (52.6% faster)
Image modifyAlpha removeColor (SIMD off) 218.000 ms
Image modifyAlpha removeColor (SIMD on) 138.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.633x (36.7% faster)
Image PNG encode (SIMD off) 973.000 ms
Image PNG encode (SIMD on) 793.000 ms
Image PNG encode ratio (SIMD on/off) 0.815x (18.5% faster)
Image JPEG encode 500.000 ms

@shai-almog shai-almog changed the title Revert #5010 changes: unreliable reporter, no confirmed underlying issue Revert #5010 changes: no confirmed underlying issue May 26, 2026
@shai-almog shai-almog merged commit 2735bb3 into master May 26, 2026
25 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant