Skip to content

fix(JavaSE): NetworkMonitor stretches with the simulator window (#3701)#5131

Merged
shai-almog merged 1 commit into
masterfrom
fix-3701-network-monitor-resize
May 31, 2026
Merged

fix(JavaSE): NetworkMonitor stretches with the simulator window (#3701)#5131
shai-almog merged 1 commit into
masterfrom
fix-3701-network-monitor-resize

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

@shai-almog shai-almog commented May 30, 2026

Summary

  • `NetworkMonitor` now implements `Scrollable` so it tracks viewport width when wrapped in a JScrollPane (single-window mode via `AppPanel.setScrollable`).
  • `showInNewWindow` picks a sane 1100x700 default (capped to screen size) instead of `pack()`'s tiny preferred dimension.
  • The split pane gets `resizeWeight=0.25` and a divider location proportional to the new window width so the request list grows with the window.

Fixes #3701 — on ultrawide monitors the Network Monitor no longer stays pinned at its packed width.

Test plan

  • Compiles (`-Plocal-dev-javase`)
  • Manual: launch simulator with Network Monitor on a wide screen, confirm pane fills horizontally and request list+detail tabs grow with window.

🤖 Generated with Claude Code

@shai-almog @claude
fix(JavaSE): NetworkMonitor resizes with the simulator window (#3701)
b7308c5 
Two fixes for the Network Monitor pane:

1. NetworkMonitor implements Scrollable so when AppPanel.setScrollable
   wraps it in a JScrollPane (single-window mode), the inner content
   tracks the viewport width and fills available horizontal space
   instead of leaving a fixed-width column with empty trailing area.

2. showInNewWindow now picks a sane default size (1100x700 capped to
   the active screen) and sets the split-pane resize weight so extra
   width is split between the request list and the detail tabs rather
   than dumped onto the right pane.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented May 30, 2026 •
edited
Loading

JavaSE simulator screenshot updates

Compared 11 screenshots: 10 matched, 1 updated.

  • javase-single-network-monitor — updated screenshot. Screenshot differs (2200x1400 px, bit depth 8).

    javase-single-network-monitor
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 1540x980.
    Full-resolution PNG saved as javase-single-network-monitor.png in workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 30, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ✅ ByteCodeTranslator: 0 findings (no issues)
    • ✅ android: 0 findings (no issues)
    • ✅ codenameone-maven-plugin: 0 findings (no issues)
    • ✅ core-unittests: 0 findings (no issues)
    • ✅ ios: 0 findings (no issues)
  • ✅ PMD: 0 findings (no issues) [Report archive]
  • ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@shai-almog shai-almog merged commit 39a450d into master May 31, 2026
13 checks passed
@shai-almog shai-almog deleted the fix-3701-network-monitor-resize branch May 31, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Simulator "Network Monitor" doesn't resize (as the other Simulator windows do)

1 participant

@shai-almog