Give every generated guide snippet a copyright header - #5702
Open
shai-almog wants to merge 1 commit into
Open
Conversation
226 of the 618 files under snippets/generated had no header at all. The gate is diff-scoped, so it only ever looked at them when a PR happened to touch one -- which meant the omission surfaced as a surprise failure three times while restoring code samples, each time in a file whose actual change was a line or two of Java. The header is the Codename One GPLv2 with Classpath exception, copied verbatim from a file in the same directory that already passes, so nothing new is being invented. The 2012 form is the one used by 315 of the already-headered files here and 747 across CodenameOne/src; the 77 carrying 2026 are left as they are. The change is exactly additive: 23 lines at the top of each file and nothing else, with each file's own line endings preserved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
226 of the 618 files under
snippets/generatedhad no copyright header at all.check-copyright-headers.shis diff-scoped, so it only ever looked at those fileswhen a PR happened to touch one. That turned the omission into a surprise CI failure
three separate times while restoring code samples — each time in a file whose actual
change was a line or two of Java, and each time costing a round trip.
The header is the Codename One GPLv2 with Classpath exception, copied verbatim from a
file in the same directory that already passes the gate, so nothing new is invented. The
2012 form is what 315 of the already-headered files here use, and 747 files across
CodenameOne/src; the 77 carrying 2026 are left alone. Easy to overrule if you'd rathernew headers carried the current year — say so and I'll reroll.
The change is strictly additive and mechanical:
Verified locally: demos compile plus the bytecode compliance check,
validate-guide-snippetsstill resolves all 1028 include-backed blocks, control-character check clean over all 226,
and
check-copyright-headers.sh --base origin/masternow reports 226 passed.Touches no shared file — no ratchet baseline, no workflow, no chapter — so it's disjoint
from #5698.
🤖 Generated with Claude Code