feat: opencode initial prompt hack test #137
Open
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Preview binaries are ready! To test with modules: |
johnstcn
reviewed
Nov 7, 2025
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
Is this still a 'hack' as per the PR title? Has your testing turned up any further information?
| for i := len(lines) - 1; i >= 1; i-- { | ||
| if strings.TrimSpace(lines[i-1]) == "" && | ||
| for i := len(lines) - 1; i >= 2; i-- { | ||
| if strings.ReplaceAll(lines[i-2], " ", "") != "┃┃" && |
Member
There was a problem hiding this comment.
Can you add a test that fails without this change please?
| } | ||
|
|
||
| func formatOpencodeMessage(message string, userInput string) string { | ||
|
|
Comment on lines
+331
to
+337
| if s.agentType == mf.AgentTypeOpencode { | ||
| time.Sleep(5 * time.Second) | ||
| // If we still have it as stable, go ahead. | ||
| if convertStatus(s.conversation.Status()) != AgentStatusStable { | ||
| continue | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The reason for this change isn't clear. Can you add some clearer comments as to why we need to wait 5 seconds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like this.Thinking of a better way to approach Initial prompt, also wondering why it fails on coder (remote) but works on local agentapi, is it because of latency? Will need to test that out with a debug PR.
cc: @matifali @johnstcn