-
Notifications
You must be signed in to change notification settings - Fork 92
feat: opencode initial prompt hack test #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
35C4n0r
wants to merge
19
commits into
coder:main
Choose a base branch
from
35C4n0r:feat-opencode-initial-prompt-hack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−2
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8efee81
feat: opencode initial prompt hack test
35C4n0r c8e93c3
wip
35C4n0r 3001416
wip
35C4n0r 192cbea
wip
35C4n0r 1879466
wip
35C4n0r b054d2e
wip
35C4n0r 21629b8
wip
35C4n0r 0393c07
wip
35C4n0r 8d51c68
wip
35C4n0r 6d0f987
wip
35C4n0r bd2d126
wip
35C4n0r a18875d
wip
35C4n0r e6b40a1
wip
35C4n0r 5486d31
wip
35C4n0r 55a9ea0
wip
35C4n0r a0c464e
wip
35C4n0r ac81408
wip
35C4n0r f1c653e
wip
35C4n0r c70bf83
wip
35C4n0r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,8 +70,8 @@ func removeOpencodeMessageBox(msg string) string { | |
| // ┃ ┃ | ||
| // We only check for the first ┃ and then an empty line above it - as sometimes the full input block does not load within a snapshot, | ||
| // this leads to displaying a bunch of newlines. | ||
| for i := len(lines) - 1; i >= 1; i-- { | ||
| if strings.TrimSpace(lines[i-1]) == "" && | ||
| for i := len(lines) - 1; i >= 2; i-- { | ||
| if strings.ReplaceAll(lines[i-2], " ", "") != "┃┃" && | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a test that fails without this change please? |
||
| strings.ReplaceAll(lines[i], " ", "") == "┃┃" { | ||
| lines = lines[:i-1] | ||
| break | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -262,6 +262,7 @@ func formatCodexMessage(message string, userInput string) string { | |||
| } | ||||
|
|
||||
| func formatOpencodeMessage(message string, userInput string) string { | ||||
|
|
||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
| message = RemoveUserInput(message, userInput, AgentTypeOpencode) | ||||
| message = removeOpencodeMessageBox(message) | ||||
| message = trimEmptyLines(message) | ||||
|
|
||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this change isn't clear. Can you add some clearer comments as to why we need to wait 5 seconds?