🤖 Add overflow_policy to prevent git status temp file spam #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `overflow_policy: 'truncate' | 'tmpfile'` option to bash execution that prevents temp file spam from background git status polling. ## Problem GitStatusStore and GitStatusIndicator poll git status every 3 seconds. When output exceeds 16KB limit, bash tool writes full output to temp files, causing console spam: ``` [gitStatus] Script failed: [OUTPUT OVERFLOW - ...] Full output saved to /var/folders/.../bash-ffe12c1a.txt ``` Background operations don't need full output - they just fail silently. ## Solution Add `overflow_policy` config option (not exposed to AI): - `'truncate'` - Return first 50 lines inline, no temp file - `'tmpfile'` - Current behavior (default for AI operations) ## Changes 1. **Core implementation** (bash.ts): - Check `config.overflow_policy ?? 'tmpfile'` in truncation handler - Truncate: return first 50 lines with error message - Tmpfile: write full output to temp file (default behavior) 2. **Type plumbing**: - Add `overflow_policy?` to ToolConfiguration interface - Pass through IPC types and ipcMain handler - NOT exposed in AI tool schema (verified) 3. **Usage**: - GitStatusStore: use `overflow_policy: 'truncate'` for status checks - GitStatusStore: use `overflow_policy: 'truncate'` for git fetch - GitStatusIndicator: use `overflow_policy: 'truncate'` for popover ## Testing Added 2 new tests: - Verify truncate policy returns first 50 lines, no temp file - Verify default (no policy) uses tmpfile behavior All 504 tests pass. Typecheck passes. _Generated with `cmux`_
All executeBash IPC calls are from UI (background operations). AI uses bash tool directly (not through IPC), so always gets tmpfile. Simplifications: - Remove overflow_policy from IPC types - Hardcode overflow_policy: 'truncate' in ipcMain handler - Remove overflow_policy from all call sites (GitStatusStore, GitStatusIndicator) Result: Same behavior, less configuration surface area. _Generated with `cmux`_
ammario
approved these changes
Oct 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
Reduces console noise from background git status polling by increasing the bash truncate limit. ## Changes ### Increase bash truncate limit to 80 lines Changed from 50 → 80 lines for the `truncate` overflow policy. This provides better debugging context for git status output while still preventing excessive spam. **Before (50 lines):** - Too restrictive for useful debugging - Git status output often cut off mid-info **After (80 lines):** - Provides better context for git operations - Still prevents console flooding - Only affects IPC bash calls (background operations) ## Note on SHOW_BRANCH truncation Initially considered truncating `git show-branch` output before parsing, but this would break ahead/behind counting in `parseGitShowBranchForStatus` which iterates all commit lines. The 80-line truncate limit is sufficient for most cases, and the `truncate` overflow policy ensures we don't spam temp files. ## Dependencies Built on top of #256 which adds the `overflow_policy` feature. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes console log spam from background git status polling operations.
Problem
GitStatusStore and GitStatusIndicator poll git status every 3 seconds. When output exceeds the 16KB limit, the bash tool writes full output to temp files, causing console spam:
Background operations don't need full output - they just fail silently.
Solution
Added
overflow_policy: 'truncate' | 'tmpfile'configuration option:'truncate'- Returns first 50 lines inline, no temp file (for background ops)'tmpfile'- Writes full output to temp file (default, for AI operations)The option is NOT exposed to AI - it's only available through internal configuration.
Changes
overflow_policy?toToolConfigurationinterfaceoverflow_policy: 'truncate'to GitStatusStore and GitStatusIndicatorTesting
Generated with
cmux