🤖 Limit git status output to reduce console spam #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ammar-agent
force-pushed
the
limit-git-status-output
branch
from
ab27a9e to
c4183fc
Compare
Two improvements to reduce noise from background git status operations: 1. **Limit SHOW_BRANCH output to 20 lines** - Git repos with long histories can have hundreds of commits - Now truncates to 20 lines with "... (N more commits omitted)" message - Prevents console from being flooded with commit history 2. **Increase bash truncate output from 50 to 80 lines** - 50 lines was too restrictive for useful debugging - 80 lines provides better context while still preventing spam - Only affects IPC bash calls (background operations) These changes make git status polling less noisy while still providing useful information for debugging. _Generated with `cmux`_
Add --more=50 flag to git show-branch in GitStatusIndicator popover to prevent overflow when branches have many commits. 50 commits is more than enough for the hover preview while preventing console spam from the truncate policy. _Generated with `cmux`_
ammar-agent
force-pushed
the
limit-git-status-output
branch
from
f66a72f to
ba34c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces console noise from background git status polling by increasing the bash truncate limit.
Changes
Increase bash truncate limit to 80 lines
Changed from 50 → 80 lines for the
truncateoverflow policy. This provides better debugging context for git status output while still preventing excessive spam.Before (50 lines):
After (80 lines):
Note on SHOW_BRANCH truncation
Initially considered truncating
git show-branchoutput before parsing, but this would break ahead/behind counting inparseGitShowBranchForStatuswhich iterates all commit lines. The 80-line truncate limit is sufficient for most cases, and thetruncateoverflow policy ensures we don't spam temp files.Dependencies
Built on top of #256 which adds the
overflow_policyfeature.Generated with
cmux