🤖 Optimize make static-check (74% faster)
#288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds up static-check from 18.5s to 4.8s for incremental changes (74% improvement). **Changes:** 1. **Enable parallel-by-default** - Add MAKEFLAGS += -j to Makefile - Independent checks (lint, typecheck, fmt-check, etc.) now run concurrently - 18.5s → 13s for cold cache 2. **Enable ESLint caching** - Add --cache flag to scripts/lint.sh - Caches lint results per file, only re-lints changed files - 13s → ~1s for incremental changes (only changed files re-linted) - Cache file (.eslintcache) is gitignored **Performance:** - Cold cache (CI): 18.5s → 13s (30% faster) - Hot cache (dev): 18.5s → 4.8s (74% faster) **Safety:** - Targets requiring sequential execution use .NOTPARALLEL (already in place) - ESLint cache invalidates automatically on config changes - No change to CI behavior (cache starts empty) _Generated with `cmux`_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR.
The previous implementation unconditionally set MAKEFLAGS += -j, which overrode user-provided -j flags (e.g., make -j1 would still run in parallel). Now we only default to parallel execution if the user didn't explicitly provide a -j flag, properly respecting their choice. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up static-check from 18.5s to 4.8s for incremental changes (74% improvement).
Changes
Enable parallel-by-default - Add
MAKEFLAGS += -jto MakefileEnable ESLint caching - Add
--cacheflag to scripts/lint.shPerformance
Implementation Details
Parallel-by-default
MAKEFLAGS += -jto enable parallel execution by default-j1for sequential).NOTPARALLELdirective for build-main ensures safety where neededESLint cache
.eslintcache) stores lint results keyed by file contentTesting
Verified performance with:
Generated with
cmux