Skip to content

🤖 Optimize make static-check (74% faster) #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

🤖 Optimize make static-check (74% faster) #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c29d0d
🤖 Optimize `make static-check` performance
ammar-agent Oct 17, 2025
798d9a4
Fix: Respect user-provided -j flags in Makefile
ammar-agent Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ yarn-error.log
# testing
/coverage

# ESLint cache for faster incremental lints
.eslintcache

# Bun
bun.lockb
dist
Expand Down
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
# make test - Run tests
#
# Parallelism:
# Use make -jN to run independent tasks concurrently (e.g., make -j4 build)
# Runs in parallel by default for faster builds. Use -j1 for sequential execution.
# Individual targets can opt out with .NOTPARALLEL if needed.
#
# Backwards Compatibility:
# All commands also work via `bun run` (e.g., `bun run dev` calls `make dev`)
Expand All @@ -23,6 +24,11 @@
# Branches reduce reproducibility - builds should fail fast with clear errors
# if dependencies are missing, not silently fall back to different behavior.

# Enable parallel execution by default (only if user didn't specify -j)
ifeq (,$(filter -j%,$(MAKEFLAGS)))
MAKEFLAGS += -j
endif

# Include formatting rules
include fmt.mk

Expand Down
4 changes: 2 additions & 2 deletions scripts/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ ESLINT_PATTERN='src/**/*.{ts,tsx}'

if [ "$1" = "--fix" ]; then
echo "Running bun x eslint with --fix..."
bun x eslint "$ESLINT_PATTERN" --fix
bun x eslint --cache "$ESLINT_PATTERN" --fix
else
echo "Running eslint..."
bun x eslint "$ESLINT_PATTERN"
bun x eslint --cache "$ESLINT_PATTERN"
echo "ESLint checks passed!"
fi