🤖 Optimize Review tab syntax highlighting with CSS classes #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set useInlineStyles={false} in react-syntax-highlighter to reduce
JavaScript computation overhead by using CSS classes instead of
computing style objects at runtime.
This is a simple performance optimization that offloads styling work
from JS to CSS. If highlighting is still slow, we can explore more
aggressive optimizations like viewport-based rendering.
Generated with `cmux`
When useInlineStyles={false}, react-syntax-highlighter outputs CSS class names
(.token.keyword, .token.string, etc.) instead of computing inline styles. This
CSS file provides the actual styling rules.
Generated from vscDarkPlus theme with backgrounds removed to preserve diff
background colors in the Review tab.
- Created scripts/generate_prism_css.ts to generate CSS from vscDarkPlus theme - Filters out font-family and font-size to inherit from parent (DiffContainer) - Preserves project font standards: var(--font-monospace) and 12px default - Updated CSS with regeneration instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
useInlineStyles={false}is enabled in react-syntax-highlighter, the library outputs CSS class names (.token.keyword,.token.string, etc.) instead of computing inline styles at runtime. This reduces JavaScript overhead, but requires actual CSS stylesheets to be loaded.Solution
prism-syntax.cssfrom vscDarkPlus theme with backgrounds removeduseInlineStyles={false}prop is activeTesting
Related
useInlineStyles={false}propGenerated with
cmux