🤖 Persist FileTree expand/collapse state per workspace #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use existing usePersistedState pattern to remember directory expand/collapse
preferences across workspace switches. State is stored in localStorage with
workspace-scoped key 'fileTreeExpandState:{workspaceId}'.
Implementation follows the same pattern as hunk expand state (PR #332):
- Store expand state as Record<string, boolean> keyed by node path
- Default to expanded for first 2 levels if no manual state exists
- Use { listener: true } for cross-component synchronization
- State is copied on workspace fork and deleted on workspace removal
Benefits:
- Users don't need to re-expand folders after switching workspaces
- Reduces cognitive load when navigating between workspaces
- Consistent UX with hunk expand/collapse behavior
ammar-agent
force-pushed
the
filetree-persist-toggle-state
branch
from
3309c27 to
bfaa64d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Previously every TreeNodeContent subscribed to the same storage key, causing O(total nodes) re-renders on each toggle. Now FileTree owns the persisted state and passes it down, so only affected branches re-render on expand/collapse. Addresses Codex P1 review comment.
Removed redundant background from DiffContainer. The individual diff lines (DiffLineWrapper) already have appropriate backgrounds for add/remove lines, so the container background was creating a double-layer grey effect. Also added 'background: transparent' to pre/code elements in prism-syntax.css and updated the generation script for future regenerations. Resolves double-grey background issue in FileEditToolCall diffs.
ammar-agent
force-pushed
the
filetree-persist-toggle-state
branch
from
59648a5 to
56a90ab
Compare
Added --color-code-bg variable (hsl(0deg 6.43% 8.04%)) in colors.tsx and replaced all hardcoded rgba(0, 0, 0, 0.2) code backgrounds with it. Ensures consistent appearance across: - DiffContainer (file edits, review diffs) - HunkContent (review panel hunks) - Tool call displays (file read, bash, etc.) - Markdown code blocks - Mermaid diagrams Single source of truth prevents inconsistent shades of grey.
ammar-agent
force-pushed
the
filetree-persist-toggle-state
branch
from
3718403 to
0fcc420
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #335 (syntax highlighting perf) with FileTree state persistence.
Problem
FileTree directory expand/collapse state resets on workspace switch, forcing users to re-expand directories every time.
Solution
Use existing pattern to remember directory expand state per workspace:
Record<string, boolean>keyed by node path{ listener: true }for cross-component syncImplementation
Follows exact pattern from hunk expand state (PR #332):
getFileTreeExpandStateKey(workspaceId)tostorage.tsPERSISTENT_WORKSPACE_KEY_FUNCTIONSfor cleanup/copyFileTreecomponent to useusePersistedStateinstead ofuseStateworkspaceIdfromReviewPanel→FileTree→TreeNodeContentTesting
Generated with
cmux