🤖 Open markdown links externally and add PWA support #359
Conversation
- Add custom anchor component to markdown renderer that opens all links with target='_blank' and rel='noopener noreferrer' - Add PWA manifest with app metadata, icons, and shortcuts - Add service worker for offline support and caching - Register service worker in main.tsx - Update index.html with PWA meta tags and manifest link This fixes the issue where clicking links in markdown (like web/server docs) would replace the entire app window instead of opening externally. Generated with `cmux`
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.addEventListener('fetch', (event) => { | ||
| event.respondWith( | ||
| fetch(event.request) | ||
| .then((response) => { | ||
| // Clone the response before caching | ||
| const responseToCache = response.clone(); | ||
| caches.open(CACHE_NAME) | ||
| .then((cache) => { | ||
| cache.put(event.request, responseToCache); | ||
| }); |
There was a problem hiding this comment.
The fetch handler caches every request (including POST or long‑lived fetch streams) by cloning the response and writing it to the default cache. This means SSE/chat streams from the backend will be duplicated and buffered until completion so they can be cached, which in practice never happens and causes the service worker to keep consuming the stream indefinitely, increasing memory usage and potentially stalling updates. Limit caching to static GET asset requests (e.g. by checking event.request.method === "GET" and filtering by pathname) instead of intercepting every network call.
Useful? React with 👍 / 👎.
The PWA files (manifest.json, icons, service-worker.js) were not being included in the published NPM package, causing 404 errors when the app tries to load them. ## Problem When PWA support was added in #359, the `public/` directory files were correctly set up for local development and Electron builds, but they weren't being included in the NPM package distribution. This caused 404 errors for users installing via npm. ## Solution 1. **Updated build-static target** - Added `cp -r public/* dist/` to copy PWA assets during build 2. **Updated package.json files field** - Added `dist/**/*.json` and `dist/**/*.png` patterns to include the PWA files in the published package ## Verification Confirmed with `npm pack --dry-run`: - ✓ dist/manifest.json (790B) - ✓ dist/icon-192.png (7.8kB) - ✓ dist/icon-512.png (24.0kB) - ✓ dist/service-worker.js (1.3kB) _Generated with `cmux`_
1 participant
Fixes the issue where clicking links in markdown (like web/server docs) would replace the entire app window instead of opening externally.
Changes
Markdown Links:
target='_blank'andrel='noopener noreferrer'PWA Support:
Testing
Generated with
cmux