🤖 Fix PWA manifest 404 in NPM package #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PWA files (manifest.json, icons, service-worker.js) were not being included in the published NPM package, causing 404 errors. ## Changes - Updated Makefile build-static target to copy public/ contents to dist/ - Added dist/**/*.json and dist/**/*.png to package.json files field ## Testing Verified with `npm pack --dry-run` that PWA files are now included: - dist/manifest.json (790B) - dist/icon-192.png (7.8kB) - dist/icon-512.png (24.0kB) - dist/service-worker.js (1.3kB) _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PWA files (manifest.json, icons, service-worker.js) were not being included in the published NPM package, causing 404 errors when the app tries to load them.
Problem
When PWA support was added in #359, the
public/directory files were correctly set up for local development and Electron builds, but they weren't being included in the NPM package distribution. This caused 404 errors for users installing via npm.Solution
cp -r public/* dist/to copy PWA assets during builddist/**/*.jsonanddist/**/*.pngpatterns to include the PWA files in the published packageVerification
Confirmed with
npm pack --dry-run:Generated with
cmux