fix: send coder User-Agent on all deployment requests - #7
Merged
Conversation
jeremyruppel
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.NET's
HttpClientomitsUser-Agentby default, causing AWS WAF to reject requests with403(NoUserAgent_HEADER). This blocked both sign-in (/api/v2/buildinfo) and Coder Connect tunnel binary downloads. Additionally, shipped assemblies defaulted to version1.0.0because packaging scripts omitted/p:Version.What changed
CoderSdk/UserAgent.cs: FormatsUser-Agentas<token>/<version> (<goos>/<goarch>)(e.g.,coder-desktop/0.8.4 (linux/amd64)).JsonHttpClient,CoderApiClient, andAgentApiClientto setDefaultRequestHeaders.UserAgentvia a CoderComponent enum (DesktoporCore). Caller-supplied headers still take precedence.Vpn.Service: UpdatedManager.csandDownloader.csto identify asCoderComponent.Corefor service and tunnel binary downloads./p:Versioninbuild-release-packages.shandPKGBUILDso published assemblies carry true release versions.Validation
UserAgentTest, +2DownloaderTest). Included mutation checks to verify test coverage onDefaultRequestHeaders.debandtar.gzbuild cleanly withVERSION=0.9.0.