fix: tests: buffer the logSource channel#203
Merged
Merged
Conversation
johnstcn
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: fakeAgentAPI.PostLogSource sends on an unbuffered logSource channel, which blocks the HTTP handler goroutine if a second PostLogSource call arrives after the test has stopped reading (e.g. from a Kubernetes-spawned pod retrying after a context canceled), causing httptest.Server.Close() to deadlock waiting for the handler to finish.
Fix: Buffer the logSource and logs channels with a capacity of 32, allowing the fake server to absorb all incoming calls without blocking regardless of whether the test is actively reading.
example failure: https://github.com/coder/coder-logstream-kube/actions/runs/27814097460/job/82310947374?pr=201#step:5:472
prior to making changes when testing with:
it would produce a failure rate of 4/100.
post change testing again resulted in 0 failures.
created in Mux with the help of Claude