fix: prevent extending if template disallows#13182
Merged
BrunoQuaresma merged 6 commits intomainfrom May 8, 2024
Merged
Conversation
BrunoQuaresma
changed the title
✔️ PR 13182 Updated successfully.
|
Contributor
Author
|
@stirby I would appreciate your QA on this PR since auto stop has been a sensitive feature. |
aslilac
approved these changes
May 6, 2024
mtojek
approved these changes
May 7, 2024
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
Tiny flake in TestWorkspaceProxyWorkspaceApps_BlockDirect/PortSharing/HTTPS but unrelated 👍
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
…o bq/fix-auto-stop
Collaborator
|
@BrunoQuaresma this is great - simple and clean solution. Validated the behavior in preview deployment, nice work. |
stirby
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13078