Conversation
|
why'd you remove the inline group tags? those were part of the design, and we never talked about removing them |
Co-authored-by: Ben Potter <ben@coder.com>
enterprise/coderd/provisionerkeys.go
Outdated
| // Currently the user-auth key orgID is hardcoded to the default org. | ||
| // This will be changed when we update the `user-auth` keys to be | ||
| // directly tied to a user ID. | ||
| if key.ID.String() == codersdk.ProvisionerKeyIDUserAuth { | ||
| continue | ||
| key.OrganizationID = organization.ID |
There was a problem hiding this comment.
This says the default org, but the organization could be any org right? The organization.ID comes from the org in the url
There was a problem hiding this comment.
Comment is confusing and will update it. The user-auth key.OrganizationID is hardcoded to the default org in the database and we are overwriting it here. The organization is valid here because it's the ID we use to query the list to begin with. It's just that for provisioners in the non-default org that use user-auth would have the default org ID returned here, so we edit the fake user-auth key to have the correct org here before returning it.
|
@aslilac tags patch lgtm, |
4 participants
Closes #14867
What this changes:
user-authgrouped provisioners