refactor: replace MUI button on TopbarButton#16212
Conversation
|
@BrunoQuaresma did the appearance of the UI change at all because of these changes? if so it could be useful to see some screenshots. |
Yes, they changed slightly. It would be better for you to review them in Chromatic: Chromatic Link. |
| onClick={() => handleAction()} | ||
| data-testid="workspace-stop-button" | ||
| > | ||
| <CircleStopIcon /> |
There was a problem hiding this comment.
Can you link to the Figma designs you are referencing for these changes? I see a the square stop icon being used instead of the circle stop icon.
There was a problem hiding this comment.
There aren’t any design references; I’m simply replacing the MUI buttons and keeping design changes minimal. Waiting for designs for every page or component with buttons could take years to complete.
Regarding the icon, I switched to CircleStopIcon for consistency since we use CirclePlayIcon for the start action. However, if you feel this change is too disruptive, I can revert it and restore the old square icon.
There was a problem hiding this comment.
I just feel like its harder to see the circle icons compared to without the circles but we can always get christin's opinion at some point
There was a problem hiding this comment.
Let’s defer to the design master @chrifro for their expert opinion 😆
2 participants
Related to #14978