feat: configure terminal font size #17305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
commented
Apr 9, 2025
| } | ||
| layout="fluid" | ||
| > | ||
| <TextField |
Member
Author
There was a problem hiding this comment.
@BrunoQuaresma I'll need your design help here.
I have troubles with validation. Currently, the page submits the form "on Blur", but unfortunately user can manually type an incorrect value (for example: 33), and the page will display an ugly validation error. Would you mind giving some advice on how we can make this form less awkward?
Ideally, the input component should accept values between 8 and 32, and reject/revert other wrong inputs.
PS. Feel free to modify the page if needed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This PR will let users customize the terminal font size using Appearance settings.