Skip to content

test(coderd/database/dbpurge): use mock db in TestPurge#19386

Merged
ethanndickson merged 1 commit intomainfrom
ethan/mock-db-test-purge
Aug 18, 2025
Merged

test(coderd/database/dbpurge): use mock db in TestPurge#19386
ethanndickson merged 1 commit intomainfrom
ethan/mock-db-test-purge

Conversation

@ethanndickson
Copy link
Copy Markdown
Member

@ethanndickson ethanndickson commented Aug 18, 2025

Closes coder/internal#906

This test was using dbmem until we removed it. Presumably we've only started seeing this test flake because it's using a real db. The test just makes sure the background job runs at all, so a mock db continues to be fine here.

No other tests in this package used dbmem, so this is the only test I've changed.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson changed the title test(database/dbpurge): use mock db in TestPurge test(coderd/database/dbpurge): use mock db in TestPurge Aug 18, 2025
@ethanndickson ethanndickson marked this pull request as ready for review August 18, 2025 04:04
@ethanndickson ethanndickson merged commit fdc9dfa into main Aug 18, 2025
39 checks passed
@ethanndickson ethanndickson deleted the ethan/mock-db-test-purge branch August 18, 2025 05:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake: coderd/database/dbpurge TestPurge - bad connection

2 participants