fix(coderd): ensure lifecycle executor has sufficient task permissions #20539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleMaywood
force-pushed
the
danielle/fix/lifecycle-executor
branch
2 times, most recently
from
4a360c9 to
4ad5bde
Compare
We recently made a change to the `wsbuilder` to handle task related logic. Our test coverage for the lifecycle executor didn't handle this scenario and so we missed the insufficient permissions. This PR adds `Update` and `Read` permissions for `Task`s in the lifecycle executor, as well as an autostart/autostop test tailored to task workspaces to verify the change.
DanielleMaywood
force-pushed
the
danielle/fix/lifecycle-executor
branch
from
4ad5bde to
6cb618c
Compare
DanielleMaywood
added
the
cherry-pick/v2.28
johnstcn
approved these changes
Oct 29, 2025
mafredri
approved these changes
Oct 29, 2025
| func TestExecutorTaskWorkspace(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| createTaskTemplate := func(t *testing.T, client *codersdk.Client, orgID uuid.UUID, ctx context.Context, defaultTTL time.Duration) codersdk.Template { |
Member
There was a problem hiding this comment.
Can we avoid duplication here? I'm fine to defer cleanup to later though.
Contributor
Author
There was a problem hiding this comment.
What thoughts do you have here? Is this related to how many similar test utilities we have for creating task templates?
Member
There was a problem hiding this comment.
Yup, similar test setups, but let's defer 👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a change to the
wsbuilderto handle task related logic. Our test coverage for the lifecycle executor didn't handle this scenario and so we missed that it had insufficient permissions.This PR adds
UpdateandReadpermissions forTasks in the lifecycle executor, as well as an autostart/autostop test tailored to task workspaces to verify the change.Anthropic's Claude Sonnet 4.5 Thinking was involved in writing the tests