Conversation
ssncferreira
approved these changes
Mar 4, 2026
Contributor
ssncferreira
left a comment
ssncferreira
left a comment
There was a problem hiding this comment.
LGTM! Super clean 🥇
…paceBuildBuilder Previously, WorkspaceBuildBuilder.doInTX() inserted provisioner jobs with empty tags and used a loop in AcquireProvisionerJob that could match other tests' pending jobs when parallel tests share a database. Add a unique tag (jobID -> "true") to each provisioner job at insert time, then use that tag in AcquireProvisionerJob to target only the correct job. This follows the same pattern used in dbgen.ProvisionerJob. Closes coder/internal#1367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, WorkspaceBuildBuilder.doInTX() inserted provisioner jobs
with empty tags and used a loop in AcquireProvisionerJob that could
match other tests' pending jobs when parallel tests share a database.
Add a unique tag (jobID -> "true") to each provisioner job at insert
time, then use that tag in AcquireProvisionerJob to target only the
correct job. This follows the same pattern used in dbgen.ProvisionerJob.
Closes coder/internal#1367