Skip to content

fix: early oidc refresh with fake idp tests (#22712) (cherry 2.31)#22716

Merged
f0ssel merged 2 commits intorelease/2.31from
release/2.31_workspace_oidc_refresh
Mar 6, 2026
Merged

fix: early oidc refresh with fake idp tests (#22712) (cherry 2.31)#22716
f0ssel merged 2 commits intorelease/2.31from
release/2.31_workspace_oidc_refresh

Conversation

@Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 6, 2026 •
edited
Loading

Confirmed manually using this branch with 5min tokens (always refreshed) and 15min tokens (refreshed after 5min elapsed)

Emyrk added 2 commits March 6, 2026 10:59
@Emyrk
chore: setting time forward for expiration math (#22687)
b5178a3 
It was set backwards, which allowed invalid refresh tokens. Making
things worse.

(cherry picked from commit c805c8c)
@Emyrk
fix: early oidc refresh with fake idp tests (#22712)
31114fc 
Wrote unit tests that implement a fake idp to verify the oauth package
actually refreshes the token

(cherry picked from commit 537260a)
@Emyrk Emyrk marked this pull request as ready for review March 6, 2026 17:05
@Emyrk Emyrk added the cherry-pick/v2.31 Needs to be cherry-picked to the 2.31 release branch label Mar 6, 2026
@Emyrk Emyrk requested a review from matifali March 6, 2026 17:45
@matifali matifali requested a review from f0ssel March 6, 2026 19:07
@f0ssel f0ssel merged commit deaacff into release/2.31 Mar 6, 2026
63 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matifali matifali matifali approved these changes

@f0ssel f0ssel Awaiting requested review from f0ssel

Assignees

@Emyrk Emyrk

Labels

cherry-pick/v2.31 Needs to be cherry-picked to the 2.31 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emyrk @matifali @f0ssel