fix(cli/sessionstore): don't run Windows keyring tests in parallel#22937
Merged
fix(cli/sessionstore): don't run Windows keyring tests in parallel#22937
Conversation
kylecarbs
force-pushed
the
fix/test-keyring-flake
branch
2 times, most recently
from
0058cfa to
fe08214
Compare
kylecarbs
changed the title
kylecarbs
force-pushed
the
fix/test-keyring-flake
branch
from
fe08214 to
2d04f50
Compare
mafredri
reviewed
Mar 11, 2026
Comment on lines
+25
to
+26
| // Not parallel: subtests hit the OS keyring which is flaky under | ||
| // concurrent access (especially Windows Credential Manager in CI). |
Member
There was a problem hiding this comment.
This should be:
//nolint:tparallel // Subtests hit ...
func TestKeyring(t *testing.T) {
Same for the other one.
Member
There was a problem hiding this comment.
tparallel or paralleltest, not sure which.
kylecarbs
force-pushed
the
fix/test-keyring-flake
branch
from
2d04f50 to
d741516
Compare
The OS keyring is a shared system resource that's flaky under concurrent access, especially Windows Credential Manager in CI. Fixes coder/internal#1370
kylecarbs
force-pushed
the
fix/test-keyring-flake
branch
from
d741516 to
96809b7
Compare
mafredri
approved these changes
Mar 11, 2026
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Oops, thought I approved earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
t.Parallel()fromTestKeyringandTestWindowsKeyring_WriteReadDelete. The OS keyring is a shared system resource that's flaky under concurrent access, especially Windows Credential Manager in CI.Fixes coder/internal#1370