feat(scripts): add develop.sh port flag#22961
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f86341cc50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/develop-script-port
branch
from
f86341c to
eab5600
Compare
|
Addressed the oversized @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eab560026f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/develop-script-port
branch
from
eab5600 to
b15c68c
Compare
|
Addressed the stale frontend preflight case so an existing Web UI on port 8080 is treated as a conflict when the requested API is not already running. @codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
--portflag toscripts/develop.shso the API can run on a non-default port--portvalues early and treat an existing dev frontend on port 8080 as a conflict when the requested API is not already runningPORTenvironment variables do not move it to a different portTesting
bash -n scripts/develop.shshellcheck -x scripts/develop.shbash scripts/develop.sh --port abcbash scripts/develop.sh --port 8080bash scripts/develop.sh --port 999999999999999999999./scripts/develop.sh --port 3001and verified:http://127.0.0.1:3001/healthzhttp://127.0.0.1:3001/api/v2/buildinfohttp://127.0.0.1:8080/healthzhttp://127.0.0.1:8080/api/v2/buildinfo127.0.0.1:8080and verified./scripts/develop.sh --port 3001exits with a conflict error