Skip to content

fix(agent/reaper): skip reaper tests in CI#23068

Merged
mafredri merged 1 commit intomainfrom
mafredri/fix-reaper-ci-skip
Mar 14, 2026
Merged

fix(agent/reaper): skip reaper tests in CI#23068
mafredri merged 1 commit intomainfrom
mafredri/fix-reaper-ci-skip

Conversation

@mafredri
Copy link
Member

@mafredri mafredri commented Mar 14, 2026

ForkReap's syscall.ForkExec and process-directed signals remain flaky in CI despite the subprocess isolation added in #22894. Restore the testutil.InCI() skip guard that was removed in that change.

Fixes coder/internal#1402

🤖 This PR was created with the help of Coder Agents, and has been reviewed by a human. 🏂🏻

ForkReap's syscall.ForkExec and process-directed signals remain
flaky in CI despite the subprocess isolation added in #22894.
Restore the testutil.InCI() skip guard that was removed in that
change.

Fixes coder/internal#1402
@mafredri mafredri marked this pull request as ready for review March 14, 2026 00:18
@mafredri mafredri enabled auto-merge (squash) March 14, 2026 00:20
@mafredri mafredri merged commit 1adc22f into main Mar 14, 2026
31 checks passed
@mafredri mafredri deleted the mafredri/fix-reaper-ci-skip branch March 14, 2026 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake: TestReapInterrupt

2 participants