chore: update to Go 1.25.6 and coder/preview to 1.08 (cherry 2.29)#23228
Merged
f0ssel merged 7 commits intorelease/2.29from Mar 25, 2026
Merged
chore: update to Go 1.25.6 and coder/preview to 1.08 (cherry 2.29)#23228f0ssel merged 7 commits intorelease/2.29from
f0ssel merged 7 commits intorelease/2.29from
Conversation
- Update Go version from 1.24.11 to 1.25.6 - Update go.mod to specify Go 1.25.6 - Update GitHub Actions setup-go default version - Update dogfood Dockerfile with new Go version and SHA256 checksum 🤖 Generated with [Claude Code](https://claude.com/claude-code) via [Coder Task](https://dev.coder.com/tasks/danny/42dcc0b6-17e1-4caf-bb44-8d6c8f346bef) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit 3ee4f6d)
…21377) Replace the external moby/moby/pkg/namesgenerator dependency with an internal implementation using gofakeit/v7. The moby package has ~25k unique name combinations, and with its retry parameter only adds a random digit 0-9, giving ~250k possibilities. In parallel tests, this has led to collisions (flakes). The new internal API at coderd/util/namesgenerator eliminates the external dependnecy and offers functions with explicit uniqueness guarantees. This PR also consolidates fragmented name generation in a few places to use the new package. | Old (moby/moby) | New | |-------------------------------------|------------------------| | namesgenerator.GetRandomName(0) | NameWith("_") | | namesgenerator.GetRandomName(>0) | NameDigitWith("_") | | testutil.GetRandomName(t) | UniqueName() | | testutil.GetRandomNameHyphenated(t) | UniqueNameWith("-") | namesgenerator package API: - NameWith(delim): random name, not unique - NameDigitWith(delim): random name with 1-9 suffix, not unique - UniqueName(): guaranteed unique via atomic counter - UniqueNameWith(delim): unique with custom delimiter Names continue to be docker style `[adjective][delim][surname]`. Unique names are truncated to 32 characters (preserving the numeric suffix) to fit common name length limits in Coder. Related test flakes: coder/internal#1212 coder/internal#118 coder/internal#1068 (cherry picked from commit 091d312)
(cherry picked from commit b44a421)
Emyrk
changed the title
Emyrk
force-pushed
the
cherry/2.29_preview_update
branch
3 times, most recently
from
0af1bd0 to
f8ec178
Compare
Emyrk
force-pushed
the
cherry/2.29_preview_update
branch
from
f8ec178 to
cbf32b5
Compare
Emyrk
force-pushed
the
cherry/2.29_preview_update
branch
from
81d2c00 to
3c26612
Compare
f0ssel
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mobyfornamesgenerator(cherry picked from commit 3ee4f6d)
(cherry picked from commit 091d312)
(cherry picked from commit b44a421)