Skip to content

fix: improve inline file reference chip contrast and spacing#23285

Merged
DanielleMaywood merged 1 commit intomainfrom
fix/file-reference-chip-styling
Mar 19, 2026
Merged

fix: improve inline file reference chip contrast and spacing#23285
DanielleMaywood merged 1 commit intomainfrom
fix/file-reference-chip-styling

Conversation

@DanielleMaywood
Copy link
Contributor

🤖 This PR was authored by Coder Agent on behalf of Danielle Maywood.


Problem

The inline file reference chips (e.g. FileReferenceChip) in the agents chat used bg-surface-secondary as their background color — the same as the user message bubble. This made them visually blend in and look flat/invisible against the bubble.

There was also no horizontal spacing between chips and neighboring text, causing them to butt up against words.

Fix

  • Background: Changed from bg-surface-secondarybg-surface-tertiary so the chip has visible contrast against the message bubble.
  • Spacing: Added mx-0.5 to give breathing room between the chip and surrounding inline text.

@github-actions github-actions bot added the community Pull Requests and issues created by the community. label Mar 19, 2026
@DanielleMaywood DanielleMaywood force-pushed the fix/file-reference-chip-styling branch 4 times, most recently from 5e72278 to a99cf52 Compare March 19, 2026 13:10
Change FileReferenceChip background from bg-surface-secondary to
bg-surface-tertiary so it no longer blends into the user message
bubble (which also uses bg-surface-secondary). Add conditional
ml-0.5 / mr-0.5 at the usage site in ConversationTimeline so chips
get breathing room from neighboring text without adding stray margin
when the chip is at the start or end of the message.
@DanielleMaywood DanielleMaywood force-pushed the fix/file-reference-chip-styling branch from a99cf52 to d5d8afe Compare March 19, 2026 13:17
@DanielleMaywood DanielleMaywood marked this pull request as ready for review March 19, 2026 13:34
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦵 stamp

@DanielleMaywood DanielleMaywood merged commit 1840d6f into main Mar 19, 2026
32 checks passed
@DanielleMaywood DanielleMaywood deleted the fix/file-reference-chip-styling branch March 19, 2026 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community Pull Requests and issues created by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants