fix: match text and image attachment heights in conversation timeline#23593
Merged
fix: match text and image attachment heights in conversation timeline#23593
Conversation
Text attachments rendered by InlineTextAttachmentButton had no explicit
height, while image thumbnails used h-16 (64px). When both appeared side
by side in the sent message view, they were visibly different heights.
- Add h-16 to InlineTextAttachmentButton to match ImageThumbnail
- Switch placeholder ("Pasted text") to sans-serif text-sm with
items-center alignment instead of monospace text-xs
- Use isPlaceholder prop so real content still renders in font-mono
- Add UserMessageWithMixedAttachments story as visual regression guard
DanielleMaywood
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Text attachments (
InlineTextAttachmentButton) and image thumbnails (ImageThumbnail) rendered at different heights when displayed side by side in user messages. Text cards had no explicit height (content-driven), while images usedh-16(64px).Changes
ConversationTimeline.tsxh-16toInlineTextAttachmentButtonto matchImageThumbnailisPlaceholderprop: when the content hasn't been fetched yet (file_id path), renders "Pasted text" in sans-seriftext-smwithitems-centeralignment instead of monospacetext-xsfont-mono text-xswithformatTextAttachmentPreview()ConversationTimeline.stories.tsxUserMessageWithMixedAttachmentsstory showing a text attachment and image side by side as a visual regression guard