fix(coderd/x/chatd): archive chat hard-interrupts active stream#23758
Merged
ethanndickson merged 2 commits intomainfrom Mar 31, 2026
Merged
fix(coderd/x/chatd): archive chat hard-interrupts active stream#23758ethanndickson merged 2 commits intomainfrom
ethanndickson merged 2 commits intomainfrom
Conversation
ethanndickson
changed the title
ethanndickson
changed the title
Archiving a chat now transitions pending or running chats to waiting before setting the archived flag. This publishes a status notification on ChatStreamNotifyChannel so subscribeChatControl cancels the active processChat context via ErrInterrupted — the same codepath used by the stop button. The processChat cleanup also skips queued-message auto-promotion when the chat is archived, so archiving behaves like a hard stop rather than interrupt-and-continue.
isPendingOrRunningChatStatus was removed on main. Inline the equivalent check directly in ArchiveChat.
ethanndickson
force-pushed
the
archive-interrupts-stream
branch
from
ae01fdb to
9c5f120
Compare
ethanndickson
changed the title
Collaborator
|
Archiving an active stream should imho display a confirmation dialog in the UI. |
ibetitsmike
approved these changes
Mar 31, 2026
Member
Author
Will do in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archiving a chat now transitions pending or running chats to waiting before setting the archived flag. This publishes a status notification on
ChatStreamNotifyChannelsosubscribeChatControlcancels the activeprocessChatcontext viaErrInterrupted— the same codepath used by the stop button.The
processChatcleanup also skips queued-message auto-promotion when the chat is archived, so archiving behaves like a hard stop rather than interrupt-and-continue.Relates to #23666