Skip to content

chore: update to our fork of charm.land/fantasy with appendCompact perf improvement#24142

Merged
johnstcn merged 1 commit intomainfrom
cj/codagt-117
Apr 9, 2026
Merged

chore: update to our fork of charm.land/fantasy with appendCompact perf improvement#24142
johnstcn merged 1 commit intomainfrom
cj/codagt-117

Conversation

@johnstcn
Copy link
Copy Markdown
Member

@johnstcn johnstcn commented Apr 8, 2026

Fixes CODAGT-117

Updates go.mod to reference our forks of the following dependencies:

@johnstcn johnstcn self-assigned this Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 11:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Go module dependencies to newer internal fork revisions to pick up performance improvements (notably appendCompact) and align the Anthropic SDK fork with the coder_2_33 tracking described in the PR.

Changes:

  • Bump charm.land/fantasy replacement to a newer github.com/coder/fantasy pseudo-version (perf improvement referenced in comments).
  • Switch github.com/charmbracelet/anthropic-sdk-go replacement from github.com/kylecarbs/anthropic-sdk-go to github.com/coder/anthropic-sdk-go at a newer pseudo-version.
  • Drop github.com/charmbracelet/openai-go from go.mod indirect requirements and remove corresponding go.sum entries.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
go.mod Updates replace directives for fantasy and Anthropic SDK forks; removes unused indirect charmbracelet/openai-go requirement; adds clarifying comments.
go.sum Refreshes module checksums to match updated fork pseudo-versions and removed dependency entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod Outdated
Comment thread go.mod
@johnstcn johnstcn force-pushed the cj/codagt-117 branch 2 times, most recently from e2b6873 to 77a532d Compare April 9, 2026 11:29
Comment thread go.mod
Comment on lines +92 to +96
replace github.com/anthropics/anthropic-sdk-go v1.19.0 => github.com/dannykopping/anthropic-sdk-go v0.0.0-20251230111224-88a4315810bd

// SasSwart perf fork of openai-go with fix for WithJSONSet + deferred serialization.
// https://github.com/kylecarbs/openai-go/pull/2
replace github.com/openai/openai-go/v3 => github.com/kylecarbs/openai-go/v3 v3.0.0-20260319113850-9477dcaedcae
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: moved these up to keep them with the other perf improvements

Copy link
Copy Markdown
Member Author

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested both OpenAI and Anthropioc agents with develop.sh

@johnstcn johnstcn merged commit 27e5ff0 into main Apr 9, 2026
26 checks passed
@johnstcn johnstcn deleted the cj/codagt-117 branch April 9, 2026 12:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2026
@johnstcn
Copy link
Copy Markdown
Member Author

johnstcn commented Apr 9, 2026

@ibetitsmike does this need a cherry?

@ibetitsmike
Copy link
Copy Markdown
Collaborator

@johnstcn the token accounting thing is important, but neglibale for EA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants