Skip to content

fix: revert auto-assign agents-access role enabled#24170

Merged
johnstcn merged 2 commits intomainfrom
cj/revert/23968
Apr 8, 2026
Merged

fix: revert auto-assign agents-access role enabled#24170
johnstcn merged 2 commits intomainfrom
cj/revert/23968

Conversation

@johnstcn
Copy link
Copy Markdown
Member

@johnstcn johnstcn commented Apr 8, 2026

This reverts commit d4a9c63 (#23968).

@johnstcn johnstcn self-assigned this Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 19:36
@johnstcn johnstcn changed the title chore: revert auto-assign agents-access role enabled fix: revert auto-assign agents-access role enabled Apr 8, 2026
@coder-tasks
Copy link
Copy Markdown
Contributor

coder-tasks bot commented Apr 8, 2026

Documentation Check

Updates Needed

  • docs/ai-coder/agents/getting-started.md - Step 3 section contains a duplicate sentence: "Owners always have full access and do not need the role." appears twice. The paragraph currently reads:

    Owners always have full access and do not need the role.
    Repeat for each user who needs access. Owners always have full access and do not need the role.

    The second instance appears to be a leftover from restructuring. Suggest removing the duplicate so the section reads cleanly.


Automated review via Coder Tasks

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously-added behavior that auto-assigned the agents-access role to newly-created users when the agents experiment is enabled, restoring the requirement that an owner explicitly grants the role.

Changes:

  • Removed agents-access auto-assignment logic from CreateUser().
  • Deleted/updated tests that depended on the auto-assignment behavior.
  • Updated Agents documentation to reflect manual role assignment for users.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
coderd/users.go Removes the auto-assign agents-access role block from user creation.
coderd/users_test.go Drops the test that asserted auto-assignment under the agents experiment.
coderd/exp_chats_test.go Simplifies “no agents-access” cases now that new users won’t be auto-granted the role.
enterprise/coderd/userauth_test.go Removes enabling the agents experiment in an OIDC role-sync test (no longer needed).
docs/ai-coder/agents/getting-started.md Updates guidance to require explicitly granting the “Coder Agents User” role.
docs/ai-coder/agents/early-access.md Updates early access steps to reflect manual role granting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/ai-coder/agents/getting-started.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@johnstcn johnstcn merged commit 7b0421d into main Apr 8, 2026
28 checks passed
@johnstcn johnstcn deleted the cj/revert/23968 branch April 8, 2026 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2026
@johnstcn
Copy link
Copy Markdown
Member Author

johnstcn commented Apr 8, 2026

Cherry-pick for 2.33 here: #24173

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants