fix(coderd): reject pinning child chats in patchChat handler#24669
Merged
fix(coderd): reject pinning child chats in patchChat handler#24669
Conversation
ThomasK33
approved these changes
Apr 23, 2026
Contributor
|
thoughts on enforcing at the schema-level to prevent a regression by a possible introduction of another pin-path? |
Member
Author
Yeah but we should roll other related items in as well e.g. the archival stuff. You could also make the argument that child chats belong in their own table. |
Member
Author
|
49e2421 adds a check constraint on both pin order and archived |
DanielleMaywood
approved these changes
Apr 23, 2026
49e2421 to
1f05ddb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI already prevents child (delegated/subagent) chats from being pinned, but the
PATCH /api/experimental/chats/{chat}endpoint did not enforce this. A direct API call could pin a child chat.400 Bad Requestguard inpatchChatwhenpinOrder > 0and the chat has aParentChatIDTestChatPinOrder/RejectsChildChattestDecision log
TestChatPinOrder