test: use default provider in TestPatchChatMessage/ChangesModel#25189
Merged
Conversation
TestPatchChatMessage/ChangesModel hardcoded "openai" as the provider for the override model config. After #25171, the shared chat test harness registers a single "openai-compat" provider by default, so calling createAdditionalChatModelConfig(..., "openai", ...) fails with HTTP 400 "Chat provider is not configured" before the test can exercise the model-change path. Use defaultModel.Provider so the override always matches whatever provider the harness registered. This mirrors every other call site of createAdditionalChatModelConfig in the file.
…essage-changes-model
deansheather
approved these changes
May 12, 2026
…ers.test.ts): pass hasActiveStream to deriveMessageDisplayState deriveMessageDisplayState gained a required hasActiveStream prop in #25119, but messageHelpers.test.ts (added in the same PR) was not updated, breaking lint/ts on main. Pass hasActiveStream: false; all existing assertions exercise static messages where the prop has no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPatchChatMessage/ChangesModelhardcoded"openai"as the provider for the override model config. After #25171, the shared chat test harness registers a single"openai-compat"provider by default, so callingcreateAdditionalChatModelConfig(..., "openai", ...)fails with HTTP 400Chat provider is not configuredbefore the test can exercise the model-change path. The subtest was added in #25084 after #25171 was reviewed, so the harness change and the new hardcoded provider only met onmain.Use
defaultModel.Providerso the override always matches whatever provider the harness registered. This mirrors every other call site ofcreateAdditionalChatModelConfigin the file.Closes coder/internal#1530