Skip to content

fix: show execute tool errors#25886

Merged
ethanndickson merged 5 commits into
mainfrom
agent-workspace-cvn8-1
Jun 1, 2026
Merged

fix: show execute tool errors#25886
ethanndickson merged 5 commits into
mainfrom
agent-workspace-cvn8-1

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Jun 1, 2026

Copy link
Copy Markdown
Member

Execute tool failures that only return an error field, such as stopped-workspace connection failures, were rendered as a generic failed command without showing the backend detail.

Normalize execute results into transcript blocks so shell output and tool errors both render in the expanded command transcript, and add Storybook coverage for connection errors plus output-with-error cases.

image

edit: i've dropped the red on the danger icon, though it was pre-existing. no point alerting the user to an error the model will handle.

Closes CODAGT-530

@ethanndickson ethanndickson marked this pull request as ready for review June 1, 2026 09:23
@ethanndickson ethanndickson changed the title fix(site/src/pages/AgentsPage/components/ChatElements/tools): show execute tool errors fix: show execute tool errors Jun 1, 2026

@DanielleMaywood DanielleMaywood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the warning triangle to not be red? It indicates the user should take some action.

Comment thread site/src/pages/AgentsPage/components/ChatElements/tools/ExecuteTool.tsx Outdated
Comment thread site/src/pages/AgentsPage/components/ChatElements/tools/ExecuteTool.tsx Outdated
@ethanndickson

Copy link
Copy Markdown
Member Author

Can we change the warning triangle to not be red? It indicates the user should take some action.

ah was already done, just couldn't be bothered updating the screenshot

@ethanndickson ethanndickson merged commit 1fcb400 into main Jun 1, 2026
29 checks passed
@ethanndickson ethanndickson deleted the agent-workspace-cvn8-1 branch June 1, 2026 11:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants