Merged
Conversation
| /** | ||
| * Ensures we close the popover before calling any action handler | ||
| */ | ||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
What is the use case for this?
Contributor
Author
There was a problem hiding this comment.
Good catch, I meant to come back to this. It used to take a dependency that's no longer available, but I don't think it's the best way to handle it anyway. I switched to closing the popover on blur.
| canCancel={false} | ||
| /> | ||
| ) : ( | ||
| createWorkspaceButton("") |
Contributor
There was a problem hiding this comment.
We could change the arg to be optional, it is not intuitive what an empty string means here.
BrunoQuaresma
approved these changes
Sep 1, 2022
Contributor
BrunoQuaresma
left a comment
BrunoQuaresma
left a comment
There was a problem hiding this comment.
LGTM. Just minor comments/questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3688
Ideas for later: