Skip to content

flake: Data race in coderd - TestPatchChat/TestProvisionerJobs #1566

Description

@flake-investigator

CI Run Link: https://github.com/coder/coder/actions/runs/26971997862
Failing Job: https://github.com/coder/coder/actions/runs/26971997862/job/79592290355 (test-go-race-pg)
Commit: b95697a370a80d63a416d5fb686314e3120f754a (Garrett Delfosse) coder/coder@b95697a

Failure summary:

  • Go race detector flagged multiple coderd tests:
    • TestPatchChat/PlanMode/Clear
    • TestPatchChat/PlanMode/RejectsInvalidValue
    • TestPatchChat/Title/LengthBoundaries
    • TestProvisionerJobs/ProvisionerJobs/Single/Workspace
    • TestProvisionerJobs/ProvisionerJobs/Single/Template_Import

Race detection evidence:

testing.go:1712: race detected during execution of test
    --- FAIL: TestPatchChat/PlanMode/Clear (0.37s)
...
testing.go:1712: race detected during execution of test
    --- FAIL: TestPatchChat/PlanMode/RejectsInvalidValue (0.38s)
...
testing.go:1712: race detected during execution of test
    --- FAIL: TestPatchChat/Title/LengthBoundaries (0.00s)
...
testing.go:1712: race detected during execution of test
    --- FAIL: TestProvisionerJobs/ProvisionerJobs/Single/Workspace (0.00s)
    --- FAIL: TestProvisionerJobs/ProvisionerJobs/Single/Template_Import (0.00s)

Note: I scanned the job logs for "WARNING: DATA RACE" stack traces but only the testing.go:1712 race-detected lines were present in this run.

Root cause classification:

  • Data race (Go race detector). Multiple coderd tests in the same job were marked failed once the race was detected.

Panic/OOM checks:

  • No panic/OOM indicators found in the job logs.

Assignment analysis:

  • Intended blame targets:
    • git blame -L 4977,5065 coderd/exp_chats_test.go (TestPatchChat/PlanMode subtests)
    • git blame -L 24,110 coderd/provisionerjobs_test.go (TestProvisionerJobs/Single subtests)
  • Tooling limitation: line-level blame isn’t available here, so I used recent file history as a proxy.
    • coderd/exp_chats_test.go most recent commit: 502c5ac (Michael Suchacz / @ibetitsmike) "fix(coderd): preserve gateway model names".
    • coderd/provisionerjobs_test.go most recent commit: 7bde763b (J. Scott Miller / @jscottmiller) "feat: add workspace build transition to provisioner job list".
  • The race stack is missing, so attribution is unclear. Assigning to @ibetitsmike as the most recent meaningful modifier in the chat test area where the race first surfaced; please reassign if provisioner jobs ownership is a better fit.

Related issues searched:

  • "TestPatchChat", "TestProvisionerJobs", "exp_chats_test.go", "provisionerjobs_test.go", "race detected" — no duplicates found.

Reproduction (best effort):

go test ./coderd -run 'TestPatchChat|TestProvisionerJobs' -race -count=20

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions