🤖 fix: use atomic writes for experiments cache #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test 'refreshExperiment updates cache and writes it to disk' was flaky because fs.writeFile is not atomic - it truncates the file before writing, creating a race window where readers can see an empty or partial file. Switch to write-file-atomic which writes to a temp file then renames, making the operation atomic. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
refreshExperiment updates cache and writes it to diskwas flaky becausefs.writeFileis not atomic — it truncates the file before writing, creating a race window where readers can see an empty or partial file.Switch to
write-file-atomicwhich writes to a temp file then renames, making the operation atomic.Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high