Skip to content

🤖 fix: use atomic writes for experiments cache #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanndickson merged 1 commit into from
Dec 18, 2025
Merged

🤖 fix: use atomic writes for experiments cache #1209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node/services/experimentsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { getMuxHome } from "@/common/constants/paths";
import type { ExperimentValue } from "@/common/orpc/types";
import { log } from "@/node/services/log";
import type { TelemetryService } from "@/node/services/telemetryService";

import * as fs from "fs/promises";
import writeFileAtomic from "write-file-atomic";
import * as path from "path";

export type { ExperimentValue };
Expand Down Expand Up @@ -298,7 +300,7 @@ export class ExperimentsService {
};

await fs.mkdir(this.muxHome, { recursive: true });
await fs.writeFile(this.cacheFilePath, JSON.stringify(payload, null, 2), "utf-8");
await writeFileAtomic(this.cacheFilePath, JSON.stringify(payload, null, 2), "utf-8");
} catch {
// Ignore cache persistence failures
}
Expand Down