Skip to content

🤖 fix: quiet monitor wake events in chat - #3779

Merged
ammario merged 2 commits into
mainfrom
fix/quieter-monitor-wakes
Aug 1, 2026
Merged

🤖 fix: quiet monitor wake events in chat#3779
ammario merged 2 commits into
mainfrom
fix/quieter-monitor-wakes

Conversation

@ammar-agent

Copy link
Copy Markdown
Collaborator

Summary

Render background monitor wakes as quiet inline transcript events instead of full user-message bubbles. The raw model-facing wake prompt remains available through an expandable disclosure.

Background

Monitor wakes are machine-authored status events, but their user-bubble framing, duplicate badge, metadata row, and message actions made them visually compete with human prompts. Frequent monitor activity therefore made the chat transcript feel noisy.

Implementation

  • Route monitor wake messages to a dedicated inline event renderer before the normal user-message path.
  • Show a concise process-aware summary with expandable raw details, keyboard interaction, and a visible focus ring.
  • Remove user-message chrome and actions from monitor events.
  • Keep monitor events out of previous/next human prompt navigation.
  • Pin Storybook coverage at phone and laptop widths.

Validation

  • bun test src/browser/features/Messages/MessageRenderer.test.tsx src/browser/utils/messages/displayedMessageBuilder.bashMonitorWake.test.ts
  • make typecheck
  • make static-check
  • Storybook visual verification at 390×844 and 1200×900, including collapsed/expanded states and keyboard interaction

Risks

Low and display-focused. Wake delivery and persisted metadata are unchanged; malformed or legacy metadata continues to fall back to the ordinary user-message rendering path.


Generated with mux • Model: openai:gpt-5.6-sol • Thinking: high • Cost: $8.02

Render background monitor wakes as lightweight inline transcript events instead of user message bubbles, while keeping the raw prompt expandable and keyboard accessible.

---

_Generated with `mux` • Model: `openai:gpt-5.6-sol` • Thinking: `high` • Cost: `$8.02`_

<!-- mux-attribution: model=openai:gpt-5.6-sol thinking=high costs=8.02 -->
@ammar-agent

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8909f38a95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/features/Messages/BashMonitorWakeMessage.tsx Outdated
Wrap expanded monitor wake prompts in the transcript quote boundary so selected matched output keeps the normal quote/copy context menu behavior.

---

_Generated with `mux` • Model: `openai:gpt-5.6-sol` • Thinking: `high` • Cost: `$8.02`_

<!-- mux-attribution: model=openai:gpt-5.6-sol thinking=high costs=8.02 -->
@ammar-agent

Copy link
Copy Markdown
Collaborator Author

Addressed the quote-selection regression: expanded monitor wake details are now wrapped in TranscriptQuoteRoot with the raw prompt as the quote-text override, and the renderer test verifies the boundary.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: c7f0e6d203

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammario
ammario merged commit 11e6b96 into main Aug 1, 2026
20 of 21 checks passed
@ammario
ammario deleted the fix/quieter-monitor-wakes branch August 1, 2026 01:13
mux-bot Bot added a commit that referenced this pull request Aug 1, 2026
#3779 routes monitor wakes to a dedicated transcript component and excludes
them from prev/next prompt navigation, but each site re-derived the check as an
inline bashMonitorWake null test in a different file. Extract
isBashMonitorWakeMessage into messageUtils so both consumers agree by
construction.
@mux-bot mux-bot Bot mentioned this pull request Aug 1, 2026
mux-bot Bot added a commit that referenced this pull request Aug 1, 2026
#3779 routes monitor wakes to a dedicated transcript component and excludes
them from prev/next prompt navigation, but each site re-derived the check as an
inline bashMonitorWake null test in a different file. Extract
isBashMonitorWakeMessage into messageUtils so both consumers agree by
construction.
mux-bot Bot added a commit that referenced this pull request Aug 2, 2026
#3779 routes monitor wakes to a dedicated transcript component and excludes
them from prev/next prompt navigation, but each site re-derived the check as an
inline bashMonitorWake null test in a different file. Extract
isBashMonitorWakeMessage into messageUtils so both consumers agree by
construction.
mux-bot Bot added a commit that referenced this pull request Aug 2, 2026
#3779 routes monitor wakes to a dedicated transcript component and excludes
them from prev/next prompt navigation, but each site re-derived the check as an
inline bashMonitorWake null test in a different file. Extract
isBashMonitorWakeMessage into messageUtils so both consumers agree by
construction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants