🤖 fix: copy dependency patches into Docker builder stage - #3812
Merged
Conversation
package.json patchedDependencies references patches/@ai-sdk%2Fxai@4.0.28.patch (added in #3798), but the Dockerfile never copied patches/, so 'bun install --frozen-lockfile' fails inside the image. smoke-docker only runs on merge_group, so this slipped past PR CI and now fails every merge-queue entry.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Smoke / Dockermerge-group failure that currently blocks every merge-queue entry: the Docker builder stage never copiespatches/, sobun install --frozen-lockfilefails on thepatchedDependenciesentry added in #3798.Background
#3798 added
package.json→patchedDependencies→patches/@ai-sdk%2Fxai@4.0.28.patch.smoke-dockeronly runs onmerge_groupevents (not per-PR), so the missingCOPYwas never exercised before landing. Since then, merge-group runs fail deterministically:Observed on two consecutive merge-group runs for #3797 (31077517436, 31080586729), each with
Smoke / Dockeras the only failing job.Implementation
One
COPY patches/ patches/beforebun installin the builder stage, alongside the other install inputs (package.json,bun.lock,bunfig.toml,scripts/postinstall.sh).Validation
docker build --target builderon unpatchedorigin/main— fails with the exact CI error.Generated with
mux• Model:anthropic:claude-fable-5• Thinking:xhigh• Cost:$69.35