🤖 ci: increase runner size to 8 cores - #54
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-latest-8-cores |
There was a problem hiding this comment.
All jobs now specify runs-on: ubuntu-latest-8-cores, but GitHub-hosted runners do not provide that label. Unless the organization has created a matching self-hosted runner, each workflow will fail immediately with “No hosted runner found for: ubuntu-latest-8-cores”. To move to an 8‑core GitHub runner, use the official ubuntu-latest-{large|xlarge|2xlarge} label (and enable larger runners) or keep ubuntu-latest.
Useful? React with 👍 / 👎.
|
Thanks for the review @chatgpt-codex-connector! You're absolutely correct - After researching, I found that:
Since the standard runners now have 4 cores (double the previous 2 cores), this should provide a good performance improvement without requiring additional configuration or billing. Closing this PR as the improvement is not necessary at this time. If 8-core runners are still desired, an organization admin would need to configure larger runners first. |
|
To use Codex here, create an environment for this repo. |
05358d5 to
dab5c8f
Compare
|
You were right! 8-core runners do exist. I found the correct label format. Fixed: Changed from The correct larger runner labels follow the format This will upgrade all CI jobs from 4 cores to 8 cores, assuming the organization has larger runners enabled. |
Upgrade all CI jobs to use ubuntu-latest-8-cores runners for better performance during builds and tests. Generated with `cmux`
dab5c8f to
c565f5f
Compare
|
Updated to use |
|
Updated to use |
Switch to Depot runners with 8 cores for better performance. Generated with `cmux`
# Conflicts: # tests/ipcMain/helpers.ts # tests/ipcMain/sendMessage.test.ts
Generated with `cmux`
|
Resolved merge conflicts - CI is now running! Updated to use |
1 participant
Upgrade all CI jobs to use
depot-ubuntu-22.04-8runners for better performance during builds and tests.This uses Depot runners with 8 cores for all jobs:
Generated with
cmux