🤖 fix: restore model favorites in ChatInput #776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ORPC migration PR accidentally removed the model favorites integration from ChatInput. Restored: - defaultModel and setDefaultModel from useModelLRU() - useEffect to reset model to default when entering creation mode - defaultModel and onSetDefaultModel props passed to ModelSelector
ethanndickson
force-pushed
the
restore-model-favourites
branch
2 times, most recently
from
e226fee to
ad9a600
Compare
The ORPC migration PR accidentally removed the model favorites integration from ChatInput. Restored: - defaultModel and setDefaultModel from useModelLRU() - useEffect to reset model to default when entering creation mode - defaultModel and onSetDefaultModel props passed to ModelSelector The ModelSelector.stories.tsx WithDefaultModel story documents the feature.
ethanndickson
force-pushed
the
restore-model-favourites
branch
from
ad9a600 to
d4afd15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ORPC migration PR (#763) accidentally removed the model favorites integration from ChatInput.
What was missing
defaultModelandsetDefaultModelnot destructured fromuseModelLRU()useEffectthat resets model to default when entering creation modedefaultModelandonSetDefaultModelprops not passed toModelSelectorThe
ModelSelectorUI (star icons) anduseModelLRUhook were fine — just the integration was dropped.Testing
The existing
ModelSelector.stories.tsxWithDefaultModelstory documents this feature visually.Generated with
mux