Skip to content

🤖 fix: restore model favorites in ChatInput #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

🤖 fix: restore model favorites in ChatInput #776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90bc192
🤖 fix: restore model favorites in ChatInput
ethanndickson Nov 28, 2025
d4afd15
🤖 fix: restore model favorites in ChatInput
ethanndickson Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/browser/components/ChatInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const ChatInput: React.FC<ChatInputProps> = (props) => {
const inputRef = useRef<HTMLTextAreaElement>(null);
const modelSelectorRef = useRef<ModelSelectorRef>(null);
const [mode, setMode] = useMode();
const { recentModels, addModel, evictModel } = useModelLRU();
const { recentModels, addModel, evictModel, defaultModel, setDefaultModel } = useModelLRU();
const commandListId = useId();
const telemetry = useTelemetry();
const [vimEnabled, setVimEnabled] = usePersistedState<boolean>(VIM_ENABLED_KEY, false, {
Expand Down Expand Up @@ -178,6 +178,15 @@ export const ChatInput: React.FC<ChatInputProps> = (props) => {
[storageKeys.modelKey, addModel]
);

// When entering creation mode (or when the default model changes), reset the
// project-scoped model to the explicit default so manual picks don't bleed
// into subsequent creation flows.
useEffect(() => {
if (variant === "creation" && defaultModel) {
updatePersistedState(storageKeys.modelKey, defaultModel);
}
}, [variant, defaultModel, storageKeys.modelKey]);

// Creation-specific state (hook always called, but only used when variant === "creation")
// This avoids conditional hook calls which violate React rules
const creationState = useCreationWorkspace(
Expand Down Expand Up @@ -972,6 +981,8 @@ export const ChatInput: React.FC<ChatInputProps> = (props) => {
recentModels={recentModels}
onRemoveModel={evictModel}
onComplete={() => inputRef.current?.focus()}
defaultModel={defaultModel}
onSetDefaultModel={setDefaultModel}
/>
<TooltipWrapper inline>
<HelpIndicator>?</HelpIndicator>
Expand Down