🤖 fix: add NON_INTERACTIVE_ENV_VARS to SSHRuntime.exec() #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents git operations from blocking on editor/credential prompts when running in SSH workspaces, matching LocalRuntime behavior. - Import and apply NON_INTERACTIVE_ENV_VARS in SSHRuntime.exec() - Add test verifying env vars are set for both runtime types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
muxPrevents git operations from blocking on editor/credential prompts when running in SSH workspaces, matching LocalRuntime behavior.
Changes
NON_INTERACTIVE_ENV_VARSinSSHRuntime.exec()Before
SSHRuntime.exec()only exportedoptions.env, so SSH workspaces could hang when git tried to open an editor or prompt for credentials.After
Both
LocalRuntimeandSSHRuntimenow applyNON_INTERACTIVE_ENV_VARS(GIT_EDITOR,GIT_TERMINAL_PROMPT, etc.) to prevent blocking prompts.